Gerrit Rules

From Omni
Revision as of 22:44, 1 November 2013 by Jerdog (Talk | contribs) (Created page with "==Submitting a patch== ===The contents of your patch=== You should make sure you use different repo branches for your patch, to ensure you don’t have an unneeded dependenc...")

(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to: navigation, search

Submitting a patch

The contents of your patch

You should make sure you use different repo branches for your patch, to ensure you don’t have an unneeded dependency on another patch. Use repo start for every new changeset you make, and repo checkout to switch between your changes. For more on repo and git see Using repo and git

Your code should contain only the required changes to make your feature work. You should remove all unneeded comments (debug, commented code) and code (unneeded debug Log commands, etc).

Make sure your code style sticks to the Android Guidelines, and that you don’t have trailing spaces (spaces at the end of a line).